git.stevedylan.dev

Revert "do not call signal-unsafe function inside sighanlder" e03248a4

This reverts commit 6613d9f9a1a5630bab30bc2b70bdc793977073ee.

Discussed on the mailinglist:
https://lists.suckless.org/hackers/2207/18405.html

Hiltjo Posthuma · 2022-07-22 09:18 1 file(s) · +2 −2

dwm.c +2 −2

	Atom utf8string;

	/* clean up any zombies immediately */
	if (signal(SIGCHLD, sigchld) == SIG_ERR)
		die("can't install SIGCHLD handler:");
	sigchld(0);

	/* init screen */

void
sigchld(int unused)
{
	if (signal(SIGCHLD, sigchld) == SIG_ERR)
		die("can't install SIGCHLD handler:");
	while (0 < waitpid(-1, NULL, WNOHANG));
}


1541	1541		Atom utf8string;
1542	1542
1543	1543		/* clean up any zombies immediately */
1544		-	if (signal(SIGCHLD, sigchld) == SIG_ERR)
1545		-	die("can't install SIGCHLD handler:");
1546	1544		sigchld(0);
1547	1545
1548	1546		/* init screen */

1640	1638		void
1641	1639		sigchld(int unused)
1642	1640		{
	1641	+	if (signal(SIGCHLD, sigchld) == SIG_ERR)
	1642	+	die("can't install SIGCHLD handler:");
1643	1643		while (0 < waitpid(-1, NULL, WNOHANG));
1644	1644		}
1645	1645