we check variable == value, and not the other way - the other way is for beginner programmers.
35efafe8
1 file(s) · +15 −16
| 303 | 303 | Client *c; |
|
| 304 | 304 | XButtonPressedEvent *ev = &e->xbutton; |
|
| 305 | 305 | ||
| 306 | - | if(barwin == ev->window) { |
|
| 306 | + | if(ev->window == barwin) { |
|
| 307 | 307 | x = 0; |
|
| 308 | 308 | for(i = 0; i < LENGTH(tags); i++) { |
|
| 309 | 309 | x += textw(tags[i]); |
|
| 331 | 331 | if(CLEANMASK(ev->state) != MODKEY) |
|
| 332 | 332 | return; |
|
| 333 | 333 | if(ev->button == Button1) { |
|
| 334 | - | if((floating == layout->arrange) || c->isfloating) |
|
| 334 | + | if((layout->arrange == floating) || c->isfloating) |
|
| 335 | 335 | restack(); |
|
| 336 | 336 | else |
|
| 337 | 337 | togglefloating(NULL); |
|
| 662 | 662 | expose(XEvent *e) { |
|
| 663 | 663 | XExposeEvent *ev = &e->xexpose; |
|
| 664 | 664 | ||
| 665 | - | if(0 == ev->count) { |
|
| 666 | - | if(barwin == ev->window) |
|
| 665 | + | if(ev->count == 0) { |
|
| 666 | + | if(ev->window == barwin) |
|
| 667 | 667 | drawbar(); |
|
| 668 | 668 | } |
|
| 669 | 669 | } |
|
| 777 | 777 | int n; |
|
| 778 | 778 | XTextProperty name; |
|
| 779 | 779 | ||
| 780 | - | if(!text || 0 == size) |
|
| 780 | + | if(!text || size == 0) |
|
| 781 | 781 | return False; |
|
| 782 | 782 | text[0] = '\0'; |
|
| 783 | 783 | XGetTextProperty(dpy, w, &name, atom); |
|
| 787 | 787 | strncpy(text, (char *)name.value, size - 1); |
|
| 788 | 788 | else { |
|
| 789 | 789 | if(XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success |
|
| 790 | - | && n > 0 && *list) |
|
| 791 | - | { |
|
| 790 | + | && n > 0 && *list) { |
|
| 792 | 791 | strncpy(text, *list, size - 1); |
|
| 793 | 792 | XFreeStringList(list); |
|
| 794 | 793 | } |
|
| 1123 | 1122 | default: break; |
|
| 1124 | 1123 | case XA_WM_TRANSIENT_FOR: |
|
| 1125 | 1124 | XGetTransientForHint(dpy, c->win, &trans); |
|
| 1126 | - | if(!c->isfloating && (c->isfloating = (NULL != getclient(trans)))) |
|
| 1125 | + | if(!c->isfloating && (c->isfloating = (getclient(trans) != NULL))) |
|
| 1127 | 1126 | arrange(); |
|
| 1128 | 1127 | break; |
|
| 1129 | 1128 | case XA_WM_NORMAL_HINTS: |
|
| 1257 | 1256 | drawbar(); |
|
| 1258 | 1257 | if(!sel) |
|
| 1259 | 1258 | return; |
|
| 1260 | - | if(sel->isfloating || (floating == layout->arrange)) |
|
| 1259 | + | if(sel->isfloating || (layout->arrange == floating)) |
|
| 1261 | 1260 | XRaiseWindow(dpy, sel->win); |
|
| 1262 | - | if(floating != layout->arrange) { |
|
| 1261 | + | if(layout->arrange != floating) { |
|
| 1263 | 1262 | wc.stack_mode = Below; |
|
| 1264 | 1263 | wc.sibling = barwin; |
|
| 1265 | 1264 | if(!sel->isfloating) { |
|
| 1396 | 1395 | if(!domwfact) |
|
| 1397 | 1396 | return; |
|
| 1398 | 1397 | /* arg handling, manipulate mwfact */ |
|
| 1399 | - | if(NULL == arg) |
|
| 1398 | + | if(arg == NULL) |
|
| 1400 | 1399 | mwfact = MWFACT; |
|
| 1401 | - | else if(1 == sscanf(arg, "%lf", &delta)) { |
|
| 1400 | + | else if(sscanf(arg, "%lf", &delta) == 1) { |
|
| 1402 | 1401 | if(arg[0] == '+' || arg[0] == '-') |
|
| 1403 | 1402 | mwfact += delta; |
|
| 1404 | 1403 | else |
|
| 1513 | 1512 | return; |
|
| 1514 | 1513 | /* The double-fork construct avoids zombie processes and keeps the code |
|
| 1515 | 1514 | * clean from stupid signal handlers. */ |
|
| 1516 | - | if(0 == fork()) { |
|
| 1517 | - | if(0 == fork()) { |
|
| 1515 | + | if(fork() == 0) { |
|
| 1516 | + | if(fork() == 0) { |
|
| 1518 | 1517 | if(dpy) |
|
| 1519 | 1518 | close(ConnectionNumber(dpy)); |
|
| 1520 | 1519 | setsid(); |
|
| 1575 | 1574 | nw = 0; /* gcc stupidity requires this */ |
|
| 1576 | 1575 | for(i = 0, c = mc = nexttiled(clients); c; c = nexttiled(c->next), i++) { |
|
| 1577 | 1576 | c->ismax = False; |
|
| 1578 | - | if(0 == i) { /* master */ |
|
| 1577 | + | if(i == 0) { /* master */ |
|
| 1579 | 1578 | nw = mw - 2 * c->border; |
|
| 1580 | 1579 | nh = wah - 2 * c->border; |
|
| 1581 | 1580 | } |
|
| 1626 | 1625 | if(!sel || sel->isfixed) |
|
| 1627 | 1626 | return; |
|
| 1628 | 1627 | if((sel->ismax = !sel->ismax)) { |
|
| 1629 | - | if((floating == layout->arrange) || sel->isfloating) |
|
| 1628 | + | if((layout->arrange == floating) || sel->isfloating) |
|
| 1630 | 1629 | sel->wasfloating = True; |
|
| 1631 | 1630 | else { |
|
| 1632 | 1631 | togglefloating(NULL); |
|